GH-356 Work around 07_sslecho.t and 44_sess.t failures with older Perls on Windows. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failure described in GH-356 seems to go away with these changes. Calling 'sleep 1' before each connect to server seems to change something, simply just timing, so that the tests appear to successfully run each time.
It seems that this is the Perl bug that causes the socket failures: Perl/perl5#12979 Also add sleeps to 44_sess.t because it fails similarly to 07_sslecho.t.
…nto GH-356-fix-test-07-sslecho
h-vn
added a commit
that referenced
this pull request
Feb 2, 2022
…ls on Windows. (#366) Calling a one second sleep before each connect to the server seems fix the occasionally occurring failures. Sleep is now done when running on Windows and Perl is earlier than 5.20.0. For the details, see GH-356 and look for CloseHandle() in Perl 5.20.0 changelog. It seems that this is the Perl bug that causes the socket failures: Perl/perl5#12979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests 07_sslecho.t and 44_sess.t sometimes fail on Windows. This seems to happen with older Perls where the possible cause is this bug described, and fixed, in 5.20.0 changes:
Details in: Perl/perl5#12979