New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context leak when socket is not cloed explicitly #473

Open

nataraj-hates-MS-for-stealing-github wants to merge 1 commit into radiator-software:master from nataraj-hates-MS-for-stealing-github:master

nataraj-hates-MS-for-stealing-github commented Jan 21, 2024

Fix memory leak described in #469.

If this patch is applied, this module build with ASan enabled no longer fails on following sample:

use strict;
use Symbol qw(gensym);
use Net::SSLeay::Handle;

my @uris = ('ya.ru', 'google.com');
#my @uris = ('google.com');

for my $uri (@uris)
{
  my $ssl = gensym();
  tie(*$ssl, "Net::SSLeay::Handle", $uri, 443);
  print $ssl "GET / HTTP/1.0\r\n\r\n";

  my $response = do { local $/ = undef; <$ssl> };
}

This does not solves all ASan related problems, but reduces failed tests from 13 to 11 for me.


          Fix context leak when socket is not cloed explicitly. See radiator-so…

394d69f

…ftware#469

nataraj-hates-MS-for-stealing-github mentioned this pull request

Memory leak detected by AddressSanitizer #469

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment