Enable LibreSSL MAC secret size feature. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the MAC secret size from the cipher, rather than reaching into libssl internals. This effectively takes the OpenSSL 1.1 code path for LibreSSL 2.7.0 instead of the OpenSSL 1.0 code path.
|
I noticed the patch also updates SSL_get_server_random() accessor to use SSL_get_server_random() but does not do the respective change to SSL_get_client_random(). Should both be changed or did you intend to update get_keyblock_size() only? I'm fine with both options, especially using API calls if possible, but I thought I'd check first. -- |
h-vn
changed the base branch from
master
to
libressl-support-collect-2018-12-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the MAC secret size from the cipher, rather than reaching into
libssl internals. This effectively takes the OpenSSL 1.1 code path
for LibreSSL 2.7.0 instead of the OpenSSL 1.0 code path.