New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 477 #557
Fix issue 477 #557
Conversation
python version changed on CI
Codecov Report
@@ Coverage Diff @@
## devel #557 +/- ##
==========================================
+ Coverage 63.11% 63.39% +0.27%
==========================================
Files 21 21
Lines 2359 2371 +12
==========================================
+ Hits 1489 1503 +14
+ Misses 870 868 -2
Continue to review full report at Codecov.
|
Are these affected? radical.entk/src/radical/entk/execman/rp/task_processor.py Lines 474 to 475 in b266c75
|
You mean because of |
Your comment made me think how placeholders are resolved when there are in both sides of However, the user needs to keep in mind that EnTK does not have any knowledge of folder structure under appman.shared_data = ['folder1/file1 > folder1/file1'] and want to use td.input_staging = ['$SHARED/folder1/file1'] |
ping @lee212 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello,
this PR fixes #477. It resolves any
shared_data
directive based on a>
exists or not and pushes them to the pilot via pilot'sstage_in
method.This is unit tested as well.