Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added possibility to annotate dataflow #651

Merged
merged 9 commits into from
Aug 23, 2023
Merged

added possibility to annotate dataflow #651

merged 9 commits into from
Aug 23, 2023

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Jul 26, 2023 •
edited

based on previous PR #650

@mtitov mtitov requested a review from andre-merzky July 26, 2023 20:03
@mtitov mtitov self-assigned this Jul 26, 2023
Base automatically changed from feature/workflow_structure to devel July 31, 2023 22:55
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited

Codecov Report

Merging #651 (43fb67b) into devel (38b3c5b) will increase coverage by 0.49%.
The diff coverage is 100.00%.

❗ Current head 43fb67b differs from pull request most recent head 2f157dd. Consider uploading reports for the commit 2f157dd to get more accurate results

@@            Coverage Diff             @@
##            devel     #651      +/-   ##
==========================================
+ Coverage   70.86%   71.35%   +0.49%     
==========================================
  Files          23       23              
  Lines        2090     2126      +36     
==========================================
+ Hits         1481     1517      +36     
  Misses        609      609
Files Changed Coverage Δ
src/radical/entk/execman/rp/task_processor.py 84.23% <100.00%> (+0.13%) ⬆️
src/radical/entk/pipeline.py 89.80% <100.00%> (+0.99%) ⬆️
src/radical/entk/task.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtitov
Copy link
Contributor Author

mtitov commented Aug 9, 2023

@mturilli @andre-merzky I've responded to Polina's comments and PR is ready to be reviewed/merged

@mtitov mtitov enabled auto-merge August 9, 2023 21:01
@mtitov mtitov disabled auto-merge August 9, 2023 21:01
mturilli
mturilli reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mturilli mturilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some very minor comments. Once you consider them, IMHO it is ready to go.

src/radical/entk/pipeline.py Outdated Show resolved Hide resolved
src/radical/entk/task.py Outdated Show resolved Hide resolved
tests/test_component/test_task.py Show resolved Hide resolved
mturilli
mturilli approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mturilli mturilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mturilli mturilli merged commit 79fa789 into devel Aug 23, 2023
3 checks passed
@mturilli mturilli deleted the feature/dataflow_annotation branch August 23, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturilli mturilli mturilli approved these changes

@andre-merzky andre-merzky Awaiting requested review from andre-merzky

@infispiel infispiel Awaiting requested review from infispiel

Assignees

@mtitov mtitov

Labels
type:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtitov @mturilli @andre-merzky