Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize the schema for raptor.Master.submit_workers() *descr* parameter. #2731

Closed
eirrgang opened this issue Oct 12, 2022 · 4 comments · Fixed by #2892
Closed

Formalize the schema for raptor.Master.submit_workers() *descr* parameter. #2731

eirrgang opened this issue Oct 12, 2022 · 4 comments · Fixed by #2892

Comments

@eirrgang
Copy link
Contributor

The expected fields have been evolving for the dictionary passed as the descr argument to rp.raptor.Master.submit_workers(). Before the expected and allowed fields in the dictionary evolve further, it would be helpful to define a data structure or type hinting for this aggregate.

I think the RCT TypedDict would suffice, and the subclass docstring would be a good home for the notes currently in the submit_workers() docstring.

Also note that environment and pre_exec are currently optional fields, but are not mentioned in the submit_workers() docstring.

@andre-merzky
Copy link
Member

This will be addressed as part of #2684

@andre-merzky
Copy link
Member

andre-merzky commented Apr 10, 2023

This is now a proper TaskDescription and thus strongly typed - see #2892

@mturilli
Copy link
Contributor

@eirrgang can we close this?

@eirrgang
Copy link
Contributor Author

It is my understanding that this will be resolved when #2892 is merged. If there are remaining ambiguities, I believe they will be just documentation bugs that can be easily addressed in follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants