get_state() broken!

[oleweidner]

The unit tests consistently fail with:

    assert j1.state == j1.get_state(), "%s != %s" % (j1.state, j1.get_state())
AssertionError: Running != Running

[oleweidner]

ah, never mind. this was a race condition in the unit tests. Fixed in 13cb928

[andre-merzky]

Phew... :-)

On Sun, Apr 7, 2013 at 8:10 PM, Ole Weidner notifications@github.comwrote:

ah, never mind. this was a race condition in the unit tests. Fixed in
13cb92813cb928

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/78#issuecomment-16020059
.

Nothing is really difficult.

[oleweidner]

Yes, this was something you actually pointed out a while ago when we first wrote the tests ;-)

assert j.state == j.get_state()

Since both calls trigger a backend operation, there is actually a chance that the state changes during the comparison operation.

On Apr 7, 2013, at 14:18 , Andre Merzky notifications@github.com wrote:

Phew... :-)

On Sun, Apr 7, 2013 at 8:10 PM, Ole Weidner notifications@github.comwrote:

ah, never mind. this was a race condition in the unit tests. Fixed in
13cb92813cb928

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/78#issuecomment-16020059
.

Nothing is really difficult.
—
Reply to this email directly or view it on GitHub.

[andre-merzky]

Yes -- stupid PENDING state which has no meaning on API level... :-/ Sorry
could not waste this opportunity to rant, of course ;)

On Mon, Apr 8, 2013 at 6:49 AM, Ole Weidner notifications@github.comwrote:

Yes, this was something you actually pointed out a while ago when we first
wrote the tests ;-)

assert j.state == j.get_state()

Since both calls trigger a backend operation, there is actually a chance
that the state changes during the comparison operation.

On Apr 7, 2013, at 14:18 , Andre Merzky notifications@github.com wrote:

Phew... :-)

On Sun, Apr 7, 2013 at 8:10 PM, Ole Weidner notifications@github.comwrote:

ah, never mind. this was a race condition in the unit tests. Fixed in
13cb928<
13cb928714d1f4e01f97daf9bc3ee73ef9d5c75f>

—
Reply to this email directly or view it on GitHub<
https://github.com/saga-project/saga-python/issues/78#issuecomment-16020059>

.

Nothing is really difficult.
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/78#issuecomment-16032388
.

Nothing is really difficult.