This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
The new eval #99
Merged
The new eval #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkarni
force-pushed
the
f/eval-and-env
branch
from
e5883b8
to
0cbaaa8
Compare
jameshaydon
suggested changes
Sep 25, 2018
src/Radicle/Internal/Core.hs
Outdated
| modEnv = mappings <> closure | ||
| NonEmpty.last <$> withEnv (const modEnv) | ||
| (traverse eval body) | ||
| res <- NonEmpty.last <$> withEnv (const modEnv) (traverse eval body) |
There was a problem hiding this comment.
Should it not be traverse baseEval?
There was a problem hiding this comment.
And furthermore, can it reuse callFn.
| #t | ||
| |] | ||
| prog `succeedsWith` Boolean False | ||
|
|
||
| , testCase "redefining eval keeps access to future definitions" $ do |
jameshaydon
approved these changes
Sep 26, 2018
jkarni
force-pushed
the
f/eval-and-env
branch
from
72ea52e
to
6b3033d
Compare
This was referenced Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #98 .