Use global Link component instead of ProjectLink #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Visual diff results for latest changes ✅ There are no visual differences between |
rudolfs
force-pushed
the
rudolfs/get-rid-of-projectlink
branch
from
559f830
to
940c9fb
Compare
rudolfs
force-pushed
the
rudolfs/get-rid-of-projectlink
branch
from
39f55b4
to
730260f
Compare
rudolfs
force-pushed
the
rudolfs/get-rid-of-projectlink
branch
from
730260f
to
1226eee
Compare
sebastinez
reviewed
Jul 7, 2023
There was a problem hiding this comment.
Really nice idea 👍
Maybe we could also add the extensions and deprecated options we define inside the Renderer?
Also since we are touching marked, we could maybe also look into using a Marked instance instead of having different marked imports, and maybe have a getter for that instance, on which we call parse()?
/src/components/InlineMarkdown.svelte
11,24: dompurify.sanitize(marked.parseInline(content));
/src/components/Markdown.svelte
55,7: marked.parse(content, {
/src/lib/markdown.ts
96,10: }. ${marked.parseInline(
See: markedjs/marked#2831
|
Thanks for the review @sebastinez! I'll merge this as is for now and leave the feedback for @geigerzaehler as a follow up: https://github.com/radicle-dev/radicle-interface/issues/919. |
This way we can get rid of the project browsing specific ProjectLink component and simplify the router types. Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm> Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
rudolfs
force-pushed
the
rudolfs/get-rid-of-projectlink
branch
from
1226eee
to
74fa05c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate remaining
ProjectLinkinstances. We want to use the genericLinkcomponent everywhere to keep the router generic.