Replace marked namespaces with Marked instance #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sebastinez
force-pushed
the
sebastinez/address-comments-on-renderer
branch
from
cad09a8
to
da526b1
Compare
|
Visual diff results for latest changes ✅ There are no visual differences between |
Based on a new addition to marked, this commits replaces the imported marked namespaces with a Marked class, that doesn't change when `marked.use` introduces new options or extensions. Also changes the naming slighty to use `markdown` as module, so it sounds more generic. Reference: markedjs/marked#2831 Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
sebastinez
force-pushed
the
sebastinez/address-comments-on-renderer
branch
from
da526b1
to
69946f5
Compare
geigerzaehler
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a new addition to marked, this commits replaces the imported marked namespaces with a Marked class, that doesn't change when
marked.useintroduces new options or extensions.Also changes the naming slighty to use
markdownas module, so it sounds more generic.Reference: markedjs/marked#2831
Closes #919