Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Peer-to-peer node #696

Merged
merged 1 commit into from
Sep 2, 2021
Merged

RFC: Peer-to-peer node #696

merged 1 commit into from
Sep 2, 2021

Conversation

xla
Copy link
Contributor

@xla xla commented Jun 8, 2021 •
edited
Loading

@xla xla self-assigned this Jun 8, 2021
@xla xla changed the title rfc: Peer-to-peer node RFC: Peer-to-peer node Jun 8, 2021
@FintanH
Copy link
Contributor

FintanH commented Jun 8, 2021

Shall I close #673 in favour of this?

@xla
Copy link
Contributor Author

xla commented Jun 8, 2021

Shall I close #673 in favour of this?

Sounds good!

@FintanH FintanH mentioned this pull request Jun 8, 2021
Closed
@kim kim added the rfc Request For Comments label Jun 23, 2021
@xla xla force-pushed the xla/rfc-p2p-node branch 2 times, most recently from 59b45c2 to f9ba1eb Compare June 29, 2021 10:18
@xla xla marked this pull request as ready for review June 29, 2021 11:00
@xla xla requested a review from a team as a code owner June 29, 2021 11:00
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
FintanH
FintanH reviewed Jun 30, 2021
View reviewed changes
Copy link
Contributor

@FintanH FintanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming together! =]

docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
kim
kim reviewed Jun 30, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
xla
xla commented Jul 1, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
@xla xla mentioned this pull request Jul 1, 2021
Open
51 tasks
@xla xla force-pushed the xla/rfc-p2p-node branch 2 times, most recently from 6964dee to 7674dcf Compare July 2, 2021 07:43
@xla xla mentioned this pull request Jul 2, 2021
Open
3 tasks
@FintanH FintanH mentioned this pull request Jul 2, 2021
Merged
alexjg
alexjg reviewed Jul 13, 2021
View reviewed changes
docs/rfc/0696-p2p-node.adoc Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Show resolved Hide resolved
@FintanH FintanH mentioned this pull request Jul 28, 2021
Merged
@xla xla requested review from kim, FintanH and alexjg August 30, 2021 09:30
FintanH
FintanH previously approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@FintanH FintanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in general. I have some minor suggestions to grammar and language to help reading it :) And I think one or two questions 👀

docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
@xla xla mentioned this pull request Sep 1, 2021
Merged
FintanH
FintanH previously approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@FintanH FintanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions for 🇬🇧 Happy otherwise 😊

docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Outdated Show resolved Hide resolved
docs/rfc/0696-p2p-node.adoc Show resolved Hide resolved
@xla xla dismissed stale reviews from FintanH via ca18311 September 1, 2021 13:21
@xla
rfc: Peer-to-peer node
df1a9c7 
Signed-off-by: Alexander Simmerl <a.simmerl@gmail.com>
@xla xla merged commit 49e79d2 into master Sep 2, 2021
@xla xla deleted the xla/rfc-p2p-node branch September 2, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FintanH FintanH FintanH left review comments

@kim kim Awaiting requested review from kim

@alexjg alexjg Awaiting requested review from alexjg

Assignees

@xla xla

Labels
rfc Request For Comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xla @FintanH @kim @alexjg