refactor: part 8/7 #764
Merged
refactor: part 8/7 #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librad re-exports link-crypto, which in turn exports radicle-keystore. This can lead to a slew of compiler errors if the radicle-keystore dependency changes for one of the other crates, e.g. temporarily developing on top of a git SHA. This patch removes the dependency on radicle-keystore from the rest of the crates and imports the keystore from librad instead. Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
alexjg
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
librad re-exports link-crypto, which in turn exports
radicle-keystore. This can lead to a slew of compiler errors if the
radicle-keystore dependency changes for one of the other crates, e.g.
temporarily developing on top of a git SHA.
This patch removes the dependency on radicle-keystore from the rest of
the crates and imports the keystore from librad instead.
Signed-off-by: Fintan Halpenny fintan.halpenny@gmail.com