link-git-protocol: upgrade to latest versions of gitoxide crates #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
FintanH
reviewed
Aug 27, 2021
There was a problem hiding this comment.
Good to see you here @Byron 😄
I approved the workflow run, and it looks like you need to run cargo fmt. For all CI tests, there's a script called ci/run at the top-level.
Also we follow a DCO, so you'll need to sign your commits. So to fix this commit you can do git commit --amend -s :)
Signed-off-by: Sebastian Thiel <sebastian.thiel@icloud.com>
|
This is the first of hopefully many more PRs to come :). Also it would have helped to read the contribution guide beforehand 😅, shouldn't happen again. |
No worries, it happens :) |
|
merci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the stability guide has landed and a few major refactorings have landed along with the new
git-repository Easy mode I feel safe to kick off Byron/gitoxide#164 with
bumping the gitoxide crates to the latest available version.