Skip to content
This repository has been archived by the owner on Feb 28, 2021. It is now read-only.

Version the state #525

Merged
merged 6 commits into from Jun 17, 2020
Merged

Version the state #525

merged 6 commits into from Jun 17, 2020

Conversation

CodeSandwich
Copy link
Contributor

@CodeSandwich CodeSandwich commented Jun 16, 2020 •
edited

Fixes #496. Will squash when accepted.

@CodeSandwich CodeSandwich requested a review from a team June 16, 2020 17:09
@geigerzaehler
Copy link

This includes only the already reviewed PRs #515 and #519, right? Then this wouldn’t require a thorough review.

@NunoAlexandre
Copy link
Contributor

@CodeSandwich I would actually prefer to keep the commit history. Just sayin'

@CodeSandwich
Copy link
Contributor Author

CodeSandwich commented Jun 17, 2020 •
edited

@geigerzaehler Yes, sorry that I haven't warned about it. It's a wrap-up of these 2 PRs with a spec version bump. I still need an approval though 😬

@CodeSandwich
Copy link
Contributor Author

@NunoAlexandre Ok, I'll keep it, it's fine by me :)

@CodeSandwich CodeSandwich merged commit 5e5296a into master Jun 17, 2020
@CodeSandwich CodeSandwich deleted the versioning branch June 17, 2020 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NunoAlexandre NunoAlexandre NunoAlexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version the state
3 participants
@CodeSandwich @geigerzaehler @NunoAlexandre