Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

Handle upcoming contextIsolation breaking change in Electron #1307

Closed
geigerzaehler opened this issue Nov 23, 2020 · 0 comments · Fixed by #1693
Closed

Handle upcoming contextIsolation breaking change in Electron #1307

geigerzaehler opened this issue Nov 23, 2020 · 0 comments · Fixed by #1693
Projects
Upstream Tech

Comments

@geigerzaehler
Copy link
Contributor

Electron will use true as the default value for contextIsolation in a future release (electron/electron#23506). (At the moment we’re seeing a warning about this when starting the app.) This change will be breaking for us since the app is using the window.electron object from the preload script. The “Context Isolation” tutorial provides a solution to this.
@geigerzaehler geigerzaehler added this to the Housekeeping milestone Nov 23, 2020
@geigerzaehler geigerzaehler mentioned this issue Nov 25, 2020
Closed
@xla xla modified the milestones: Housekeeping, v0.1.1, v0.1.2, β2 Nov 25, 2020
geigerzaehler pushed a commit that referenced this issue Mar 22, 2021
fix(ui): enable Electron context isolation
51c6cee 
We enable context isolation for electron which is good security practice
and will become the default in v12. See the [tutorial][1] for details.

Fixes #1307

[1]: https://www.electronjs.org/docs/tutorial/context-isolation

Signed-off-by: Thomas Scholtes <thomas@monadic.xyz>
@geigerzaehler geigerzaehler mentioned this issue Mar 22, 2021
Merged
@geigerzaehler geigerzaehler added this to Done in Upstream Tech Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
Upstream Tech
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): enable Electron context isolation radicle-dev/radicle-upstream
2 participants
@xla @geigerzaehler