Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

Resource cleanup on crash #1352

Closed
FintanH opened this issue Nov 25, 2020 · 0 comments · Fixed by #1398
Closed

Resource cleanup on crash #1352

FintanH opened this issue Nov 25, 2020 · 0 comments · Fixed by #1398
Assignees
@geigerzaehler
Labels
bug Something isn't working
Milestone
v0.1.4

Comments

@FintanH
Copy link
Contributor

FintanH commented Nov 25, 2020

So I didn't have OpenGL which led me to having a crashed application:

(radicle-upstream:1764): GLib-GIO-ERROR **: 10:06:55.349: No GSettings schemas are installed on the system
Trace/breakpoint trap (core dumped)

I believe this ones on me and my NixOS set up. HOWEVER, none of the resources are cleaned up:

haptop    1782  0.1  0.2 417408 47108 pts/2    S    10:06   0:00 /home/haptop/.cache/appimage-run/3c717cb0fbb6b9e5e185890c8ffba853cc7b1948bd6433efcf8e13fc6d49199c/radicle-upstream --type=zygote --no-zygote-sandbox
haptop    1784  0.0  0.2 417408 46864 pts/2    S    10:06   0:00 /home/haptop/.cache/appimage-run/3c717cb0fbb6b9e5e185890c8ffba853cc7b1948bd6433efcf8e13fc6d49199c/radicle-upstream --type=zygote
haptop    1786  0.0  0.0 417408  8276 pts/2    S    10:06   0:00 /home/haptop/.cache/appimage-run/3c717cb0fbb6b9e5e185890c8ffba853cc7b1948bd6433efcf8e13fc6d49199c/radicle-upstream --type=zygote
haptop    1821  3.8  0.6 789872 111112 pts/2   Sl   10:06   0:00 /home/haptop/.cache/appimage-run/3c717cb0fbb6b9e5e185890c8ffba853cc7b1948bd6433efcf8e13fc6d49199c/radicle-upstream --type=gpu-process --field-trial-handle=11828802767480902528,6833740724110739264,131072 --enable-features=WebComponentsV0Enabled --disable-features=CookiesWithoutSameSiteMustBeSecure,SameSiteByDefaultCookies,SpareRendererForSitePerProcess --gpu-preferences=OAAAAAAAAAAgAAAQAAAAAAAAAAAAAAAAAABgAAAAAAAYAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIAAAAAAAAAA== --shared-files
haptop    1824  1.0  0.2 1400700 36708 pts/2   Sl   10:06   0:00 /home/haptop/.cache/appimage-run/3c717cb0fbb6b9e5e185890c8ffba853cc7b1948bd6433efcf8e13fc6d49199c/resources/proxy

and so a restart of my app will hit the bluescreen of death.
@FintanH FintanH added bug Something isn't working proxy labels Nov 25, 2020
@FintanH FintanH added this to the v0.1.1 milestone Nov 25, 2020
@geigerzaehler geigerzaehler self-assigned this Nov 25, 2020
@xla xla modified the milestones: v0.1.1, v0.1.2 Nov 25, 2020
@geigerzaehler geigerzaehler removed their assignment Nov 25, 2020
@xla xla modified the milestones: v0.1.2, v0.1.3 Nov 26, 2020
@geigerzaehler geigerzaehler self-assigned this Nov 26, 2020
@xla xla modified the milestones: v0.1.3, v0.1.4 Nov 27, 2020
geigerzaehler pushed a commit that referenced this issue Nov 27, 2020
fix(proxy): quit app when render process crashes
e5cca76 
We quit the app when the proxy process goes away unexpectedly.

Note that the `render-process-gone` event is not triggered if the render
process exits because the main window is closed.

Fixes #1352
@geigerzaehler geigerzaehler mentioned this issue Nov 27, 2020
Merged
@xla xla closed this as completed in #1398 Nov 27, 2020
xla added a commit that referenced this issue Nov 27, 2020
@xla
fix(proxy): quit app when render process crashes (#1398)
2765554 
We quit the app when the proxy process goes away unexpectedly.

Note that the `render-process-gone` event is not triggered if the render
process exits because the main window is closed.

Fixes #1352

Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@geigerzaehler geigerzaehler

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.1.4
Development

Successfully merging a pull request may close this issue.

fix(proxy): quit app when render process crashes radicle-dev/radicle-upstream
3 participants
@xla @FintanH @geigerzaehler