Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

WalletConnect link is broken (404) #2711

Closed
gsaslis opened this issue Jan 10, 2022 · 12 comments
Closed

WalletConnect link is broken (404) #2711

gsaslis opened this issue Jan 10, 2022 · 12 comments

Comments

@gsaslis
Copy link
Contributor

gsaslis commented Jan 10, 2022

Hi folks,

The "View compatible wallets" link ( https://walletconnect.com/wallets ) is currently broken and leads to a 404.

@gsaslis
Copy link
Contributor Author

gsaslis commented Jan 10, 2022

Screenshot 2022-01-10 at 3 37 47 PM

@rudolfs
Copy link
Member

rudolfs commented Jan 10, 2022

Good catch. Should be: https://walletconnect.com/registry/wallets.

@gsaslis
Copy link
Contributor Author

gsaslis commented Jan 10, 2022

I wanted to try and get these small patches in (also a fix for #2710 ) via upstream itself. If not, I can happily open a PR.

@geigerzaehler
Copy link
Contributor

We would be very happy if you could submit a patch via Upstream

@gsaslis
Copy link
Contributor Author

gsaslis commented Jan 10, 2022

@geigerzaehler I think I've already published the first patch, but I couldn't verify it was published successfully.

I've asked in #support channel on discord.

@rudolfs
Copy link
Member

rudolfs commented Jan 10, 2022

@gsaslis Yeah, I see the patch. Will merge it now.

@rudolfs
Copy link
Member

rudolfs commented Jan 10, 2022

One thing, it would great if you could sign-off on our DCO in future patches.
Here's how you can do it: https://github.com/radicle-dev/radicle-upstream/blob/main/docs/contributing.md#certificate-of-origin.

@gsaslis
Copy link
Contributor Author

gsaslis commented Jan 10, 2022

ah, sorry @rudolfs - I did see that guide but then forgot when trying to figure out how to submit the patch through upstream. will keep in mind for future patches, for sure! 👍🏼

@rudolfs
Copy link
Member

rudolfs commented Jan 10, 2022

No worries! There's a lot of steps to keep in mind for newcomers, we should probably update and streamline the docs.

@gsaslis
Copy link
Contributor Author

gsaslis commented Jan 10, 2022

New patch published that should fix this issue.

rudolfs added a commit that referenced this issue Jan 11, 2022
…6yu4mzqb1oqtiye/tags/radicle-patch/walletconnect-broken-link' of rad://hnrk8ueib11sen1g9n1xbt71qdns9n4gipw1o

fix: 404 broken link on wallet screen (#2711)

Fixes #2711
@parseb
Copy link

parseb commented Apr 4, 2022

Good catch. Should be: https://walletconnect.com/registry/wallets.

this link is also broken.
just downloaded the appimage and wanted to connect a wallet.

  • metamask and argent both failed. (for me)
  • the link to see compatible wallets [this][https://walletconnect.com/registry/wallets] 404s

@rudolfs
Copy link
Member

rudolfs commented Apr 19, 2022

metamask and argent both failed. (for me)

@parseb We'll be rethinking our Ethereum integration after the next release. Keep an eye on the announcements forum.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants