Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

App opens in onboarding on every app start #900

Closed
rudolfs opened this issue Sep 14, 2020 · 5 comments
Closed

App opens in onboarding on every app start #900

rudolfs opened this issue Sep 14, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@rudolfs
Copy link
Member

rudolfs commented Sep 14, 2020

Steps to reproduce:

  1. start app
  2. create identity and complete onboarding
  3. close the app
  4. start the app again

Expected outcome: the app opens in the profile view without going through onboarding again.

The identity still exists, but the session endpoint always returns an empty identity on app start:

{
  "identity": null,
  "settings": {
    "appearance": {
      "theme": "light",
      "hints": {
        "showRemoteHelper": true
      }
    },
    "coco": {
      "seeds": []
    }
  }
}

Seems like this regression was introduced in: #881. Other settings (like theme) aren't persisted either.

@rudolfs rudolfs added the bug Something isn't working label Sep 14, 2020
@rudolfs rudolfs added this to the β1 milestone Sep 14, 2020
@rudolfs rudolfs added this to To do in β1 Release Preparation via automation Sep 14, 2020
@xla xla moved this from To do to In progress in β1 Release Preparation Sep 15, 2020
@xla xla modified the milestones: β1, Housekeeping Sep 15, 2020
@xla xla added the proxy label Sep 15, 2020
@xla
Copy link
Contributor

xla commented Sep 15, 2020

Tracked down the issue being introduced in this commit: zshipko/rust-kv@9d208d4

Going to prepare a patch to integrate on a working commit and look into how to report this meaningfully to the upstrea project.

xla added a commit that referenced this issue Sep 15, 2020
A regression was introduced in our upstream dependency `kv` which breaks
the loading of our session from disk. Until we land a patch, this is the
stopgap solution.

Stop-gap for #900
xla added a commit that referenced this issue Sep 15, 2020
A regression was introduced in our upstream dependency `kv` which breaks
the loading of our session from disk. Until we land a patch, this is the
stopgap solution.

Stop-gap for #900
@rudolfs
Copy link
Member Author

rudolfs commented Sep 18, 2020

Fixed in #907.

@rudolfs rudolfs closed this as completed Sep 18, 2020
β1 Release Preparation automation moved this from In progress to Done Sep 18, 2020
@xla xla reopened this Sep 18, 2020
β1 Release Preparation automation moved this from Done to To do Sep 18, 2020
@xla
Copy link
Contributor

xla commented Sep 18, 2020

I left this open as the underlying issue wasn't addressed and we only landed a stop-gap.

@rudolfs rudolfs removed this from To do in β1 Release Preparation Sep 21, 2020
@juliendonck
Copy link
Member

@xla check this out and clooooose please

@geigerzaehler
Copy link
Contributor

@xla: I’m closing this. Feel free to reopen or create a new issue with the underlying issue details if this is still relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants