Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

Wire up waiting room with search #984

Closed
6 of 8 tasks
FintanH opened this issue Oct 1, 2020 · 1 comment
Closed
6 of 8 tasks

Wire up waiting room with search #984

FintanH opened this issue Oct 1, 2020 · 1 comment
Assignees
@xla
Projects
Project Tracking/Replication
Milestone
β1

Comments

@FintanH
Copy link
Contributor

FintanH commented Oct 1, 2020 •
edited by xla

In our haste to wire up the search feature, we cut a few corners in #969.

Tasks that come to mind that we need to do:
@FintanH FintanH added this to the β1 milestone Oct 1, 2020
This was referenced Oct 1, 2020
Merged
Closed
@FintanH FintanH moved this from To do to Grab It in Project Tracking/Replication Oct 5, 2020
@sarahscott sarahscott mentioned this issue Oct 7, 2020
Closed
6 tasks
@xla xla mentioned this issue Oct 13, 2020
Merged
xla added a commit that referenced this issue Oct 13, 2020
@xla
fix(proxy): await request urn (#1025)
2cdad05 
Regression from #992 where the future of the call was not awaited,
unfortunately our tests didn't break.

Refs #984
@xla xla mentioned this issue Oct 13, 2020
Merged
xla added a commit that referenced this issue Oct 13, 2020
@xla
refactor: move request urn endpoint to PUT (#1026)
6b249eb 
Part of #984

Instead of using POST this change converts the endpoint to PUT to
convey that the operation is idempotent. A new request for an already
requested URN should not lead to an error, instead just a noop and a
friendly message.
@xla xla mentioned this issue Oct 13, 2020
Merged
@xla xla moved this from Up for Grabs to In progress in Project Tracking/Replication Oct 14, 2020
xla added a commit that referenced this issue Oct 14, 2020
@xla @NunoAlexandre
feat(ui): check if project exists when searching (#1030)
646c50e 
Up until now we assumed the provided urn is not present in the monorepo.
This change alters the behaviour to first check if a project exists
locally - because locally sourced is best source. If it exists locally
the result box offers to navigate directly to it -- also possible with a
hit of enter. Should it not exist a track toggle is presented, which
when pressed will fire a request for the project and show a
notification.

    check for project locally first
    navigate to existing project
    request urn from the network on track toggle
    validate input to be a valid urn

Refs #984

Co-authored-by: Nuno Alexandre <hi@nunoalexandre.com>
This was referenced Oct 16, 2020
Closed
Closed
Closed
xla added a commit that referenced this issue Oct 24, 2020
@xla
feat(proxy): list project requests
1a5ec61 
Exposes an endpoint to list existing requests for projects in
preparation for a deeper UI integration.

Part of #984
This was referenced Oct 24, 2020
Merged
Merged
xla added a commit that referenced this issue Oct 26, 2020
@xla @rudolfs
feat(proxy): list project requests (#1103)
7e1aaf9 
Exposes an endpoint to list existing requests for projects in
preparation for a deeper UI integration.

Part of #984

Co-authored-by: Rūdolfs Ošiņš <rudolfs@osins.org>
xla added a commit that referenced this issue Oct 26, 2020
@xla
feat(ui): list project requests (#1104)
f0122e1 
Exposes an endpoint to list existing requests for projects in
preparation for a deeper UI integration.

Part of #984
xla added a commit that referenced this issue Oct 27, 2020
@xla
feat: cancel project search (#1105)
7377dbf 
Exposes an endpoint to list existing requests for projects in
preparation for a deeper UI integration.

Part of #984

Co-authored-by: Merle Breitkreuz <merle@monadic.xyz>
xla added a commit that referenced this issue Oct 27, 2020
@xla
feat: add project search notifications
350c479 
Adds feedback in form of notifications for cloned and timed out project
searches. Additionally keeps the following and requested lists
up-to-date when in the Following tab of the Profile to give realtime
feedback.

Part of #984
@xla xla mentioned this issue Oct 27, 2020
Merged
xla added a commit that referenced this issue Oct 28, 2020
@xla
feat: add project search notifications (#1117)
6b0d4dd 
Adds feedback in form of notifications for cloned and timed out project
searches. Additionally keeps the following and requested lists
up-to-date when in the Following tab of the Profile to give realtime
feedback.

Part of #984
@xla xla self-assigned this Oct 28, 2020
@xla
Copy link
Contributor

xla commented Oct 30, 2020

Superseded by #1147 #1148

@xla xla closed this as completed Oct 30, 2020
@juliendonck juliendonck moved this from In progress to Done in Project Tracking/Replication Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xla xla

Labels
None yet
Projects
No open projects
Project Tracking/Replication
  
Done
Milestone
β1
Development

No branches or pull requests
2 participants
@xla @FintanH