This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
refactor: isolate WalletConnect instance creation #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSandwich
approved these changes
Jul 7, 2021
geigerzaehler
force-pushed
the
thomas/wallet-qr-modal
branch
from
e5ed01c
to
d970187
Compare
We lift `newWalletConnect()` to the module-level so that it does not interact with internal `Wallet` state. Before, callbacks for the modal would set `stateStore` and internal state varibales. This significantly simplifies the connection flow. Signed-off-by: Thomas Scholtes <thomas@monadic.xyz>
geigerzaehler
force-pushed
the
thomas/wallet-qr-modal
branch
from
d970187
to
b6a1141
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lift
newWalletConnect()to the module-level so that it does not interact with internalWalletstate. Before, callbacks for the modal would setstateStoreand internal state variables. This significantly simplifies the connection flow.