This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
refactor: add localStateGet to proxy and use it exclusively
#2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geigerzaehler
force-pushed
the
thomas/proxy-local-state
branch
from
c2617cd
to
3cb0e6d
Compare
We add the `localStateGet` method to proxy client and use it exclusively. This reveals that the `managed` field on `LocalState` is not provided by the proxy and is not used. We remove it. We also remove tests from `ui/src/project.test.ts` that involve mocking the local state endpoint. Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
geigerzaehler
force-pushed
the
thomas/proxy-local-state
branch
from
3cb0e6d
to
c587f37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the
localStateGetmethod to proxy client and use it exclusively. This reveals that themanagedfield onLocalStateis not provided by the proxy and is not used. We remove it.We also remove tests from
ui/src/project.test.tsthat involve mocking the local state endpoint.