Conversation
…reset functionality to remote store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Noted some very minor things, should be good to merge otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just having a peek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. Little nitpick, I find the enum name CSSPosition
a bit clunky. It's not really a CSSPosition. It's the position of the tooltip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☢ 🌘 😌 🌃
@juliendonck the |
Opened a can of worms with this one:
Dropdown.svelte
&Option.svelte
Tooltip.svelte
ProjectCreation.svelte
& smaller children componentsProjectCreation
whereinlocalState
store persists after cancel - to reproduce onmaster
or here:- Click "New Project"
- Choose an existing project with multiple branches
- Select a branch that isn't
master
- Click "Cancel" or close the modal another way
- Click "New Project" & existing project again - the branches from the first project will still be there even though
nothing is selected