Gulp Refactor #32
Merged
Gulp Refactor #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmercer
force-pushed
the
gulp-refactor
branch
from
8bfa55d
to
946aadb
Compare
|
This looks good. Why is it NOMERGE? |
|
I'll still working on a few things.
Things not directly related to
A question for you: this project currently uses |
Yes, 1.3. Thanks. |
jfmercer
force-pushed
the
gulp-refactor
branch
2 times, most recently
from
d305c9b
to
9cd959c
Compare
jfmercer
force-pushed
the
gulp-refactor
branch
from
6bb765a
to
25f6c0b
Compare
|
@nateabele This is ready for review & merge. In addition to the description above, please note that neither the Coveralls nor the CodeClimate badge will work until merged into master. This repository needs more work, but I'll file those problems under Issues. Here are the reports: |
This commit adds gulp to `angular-model` and adds a significant
number of tasks.
* Uses `run-sequence` to manage gulp tasks
* Fixes coveralls support
* Removes coveralls task from karma.conf.js
* Adds coveralls task to gulp
* Adds jscs task and .jscsrc
* Adds jshint task and .jshintrc
* Adds security audit task with `requireSafe`
* Adds CodeClimate coverage and .codeclimate.yml
* N.B. CodeClimate checks only `angular-model.js` and
no other files.
* Removes previous build script, which is now superfluous.
Additional changes
* Changes style in the following:
* `src/angular-model.js`
* `spec/modelSpec.js`
* `config/karma.conf.js`
* `README.md`
* `package.json` changes
* Updates gulpfile packages to latest versions
* Bumps version number to 0.5.0
* Updates Nate's and Warren's contact info
* Updates repository location
* Changes uor to radify
* Adds John as a contributor
* This is necessary to allow John to publish `angular-model`
to NPM
* Adds keywords section
* Moves `modelSpec.js` from `test/` to `spec/`
* Deletes `coveralls.yml`, which is superfluous
* Adds badges to README
* Dependencies (david-dm.org)
* CodeClimate score
* Edits `CHANGELOG.md`
jfmercer
force-pushed
the
gulp-refactor
branch
from
25f6c0b
to
4c00f8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gulp Refactor
This commit adds gulp to
angular-modeland also adds a significantnumber of tasks.
run-sequenceto manage gulp tasksrequireSafeangular-model.jsandno other files.
Additional changes
src/angular-model.jsspec/modelSpec.jsconfig/karma.conf.jsREADME.mdpackage.jsonchangesangular-modelto NPM
modelSpec.jsfromtest/tospec/coveralls.yml, which is superfluousCHANGELOG.md