Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tags are not working #61

Open
gavD opened this issue Dec 8, 2015 · 4 comments
Open

tags are not working #61

gavD opened this issue Dec 8, 2015 · 4 comments

Comments

@gavD
Copy link
Contributor

gavD commented Dec 8, 2015

I told Radiian my tag would be denzel-sample. AWS actually tags instances as denzel_sample (with an underscore).

this meant that provision.sh could not see my instances to destroy old nodes.
@gavD
Copy link
Contributor Author

gavD commented Dec 8, 2015

I haven't gotten to the bottom of this yet but I'm leaving the ticket here until I figure it out

@gavD
Copy link
Contributor Author

gavD commented Dec 8, 2015

ah, ok, so seems like AWS receives the tags fine, but ec2.py converts - to _. I'll keep an eye on it further.

@Stillerman
Copy link
Contributor

ec2.py has a method to_safe that replaces "bad" characters with "_". I think radiian should not allow anything with the "bad" characters in order to avoid confusion.

https://github.com/ansible/ansible/blob/d6b74f8f92632652de8092dfacfb6620b7e8c3bc/contrib/inventory/ec2.py#L1294

@nateabele
Copy link
Member

See also #79.

@Stillerman Stillerman mentioned this issue Jun 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nateabele @gavD @Stillerman