Polygon-based extraction does not treat NaNs properly #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@astrofrog - just a reminder to review when you have a chance |
probably led to NaNs being turned to zero and then their area being set to 1
keflavich
force-pushed
the
poly_respect_nan
branch
from
fdb2cb4
to
4806d13
Compare
|
This is ready to merge pending an understanding of astropy/astropy#3278 |
since there is no change in offset with time
keflavich
added a commit
that referenced
this pull request
Jan 7, 2015
Polygon-based extraction does not treat NaNs properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cubes with NaNs in them end up with all-NaN slices if polygons are used. This PR fixes that.