Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix to region parsing #79

Merged
merged 5 commits into from Sep 12, 2017
Merged

minor fix to region parsing #79

merged 5 commits into from Sep 12, 2017

Conversation

keflavich
Copy link
Contributor

(as in title)

@keflavich
Copy link
Contributor Author

Failures are from the gui test and not having pyqt installed!

@keflavich keflavich mentioned this pull request Nov 2, 2016
Closed
astrofrog
astrofrog reviewed Nov 4, 2016
View reviewed changes
.travis.yml Outdated
@@ -50,7 +50,7 @@ matrix:
before_install:
- git clone git://github.com/astropy/ci-helpers.git
- source ci-helpers/travis/setup_conda_$TRAVIS_OS_NAME.sh
- conda install pyqt4
- conda install pyqt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want pyqt=4 otherwise 5 gets installed

@coveralls
Copy link

coveralls commented Nov 4, 2016 •
edited

Coverage Status

Coverage decreased (-0.3%) to 81.111% when pulling c6068f3 on keflavich:fix_region_reading into 43795be on radio-astro-tools:master.

@keflavich
wrong variable name
b07fb1d 
(a bunch of commits became irrelevant below)

try installing pyqt4

pyqt, not pyqt4

install qt 4

using qt5 now
@coveralls
Copy link

coveralls commented Sep 11, 2017 •
edited

Coverage Status

Changes Unknown when pulling 98708ed on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

3 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 98708ed on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 98708ed on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 98708ed on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

@coveralls
Copy link

coveralls commented Sep 12, 2017 •
edited

Coverage Status

Changes Unknown when pulling c8a4241 on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

4 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c8a4241 on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c8a4241 on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c8a4241 on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c8a4241 on keflavich:fix_region_reading into ** on radio-astro-tools:master**.

@keflavich keflavich merged commit 95dd0a9 into radio-astro-tools:master Sep 12, 2017
@keflavich keflavich deleted the fix_region_reading branch September 12, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrofrog astrofrog astrofrog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keflavich @coveralls @astrofrog