Inherit from ndcube #808
Draft
Inherit from ndcube #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Cadair let's see if we can't get this working. |
|
the cube side looks like it probably works fine, the problem is the slices (which... frankly were a little of a problem anyway... so if we can get the labor to put into this, it would be great to follow through on the refactor...) |
|
Tests are definitely not passing!! Open question:
|
This was referenced Mar 7, 2023
keflavich
force-pushed
the
ndcube-inherit
branch
from
2b7085e
to
01b0dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: let's just see what happens if we try this.