Use a local SDK #147
Merged
Use a local SDK #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for radio4000-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oskarrough
commented
Nov 1, 2023
| import components from './components/index.js' | ||
| import './index.css' | ||
|
|
||
| export default { |
There was a problem hiding this comment.
removed this because it wasn't in use, and to avoid extra re-exports as per this article that was going around some weeks ago.
There was a problem hiding this comment.
not sure our "perfs" were suffuring, but also if unused… alright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all our components load the SDK via NPM, and as such rely on the default Supabase database. So far so good.
But some times we want to use a different database. This PR routes makes sure the SDK is always accessed via ./libs/sdk.js instead of NPM. This way we can control it globally for the components in one place.