Better tracklist rendering performance #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarrough
commented
May 23, 2024
| this.setInitialValues() | ||
| this.onQuery() | ||
| // console.log('r4-supabase-query:connected->dispatching query', this.query) | ||
| // this.dispatchQuery() |
There was a problem hiding this comment.
maybe this should be enabled again
|
The mention and tag links on r4-track no longer work well with the query url stuff. HMMMMM |
|
Meh can't figure this filter query url params stuff out for now. Closing in favour of #176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as you render more than ~200 tracks you feel the browser freezing on an M2 MacBook. This is primarily due to 1) the amount of javascript work each
<r4-track>and its child components do, and 2) the CSS layout for so many elements.This PR
content:visibilitycss trick on r4-list-item to allow the browser to optimize rendering depending on viewportThe branch also touches on the query, filter and search components to eliminate double-fetching.