fix(io.default): Handle PermissionError during check #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A PermissionError while checking a file will now result in it being considered corrupt. Bonus: fixed some ham-fisted mocking in tests/io/test_lustrehsmnode.py which was not being properly cleaned up after the test finished. Closes #176
ljgray
approved these changes
May 3, 2024
ketiltrout
force-pushed
the
permissionerror_in_md5
branch
from
27de284
to
a04f503
Compare
rikvl
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
PermissionErrorwhile checking a file will now result in it being considered corrupt.Bonus: fixed some ham-fisted mocking in
tests/io/test_lustrehsmnode.pywhich was not being properly cleaned up after the test finished.Closes #176