parallel load with no attributes #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrs65
commented
Aug 16, 2023
jrs65
commented
- feat hints to override
- fix(memh5): error with distributed loading of files with datasets in groups
- ffirst
- refactor(memh5): move no selections sentinel to empty list to simplify
jrs65
force-pushed
the
parallel-load-with-no-attributes
branch
5 times, most recently
from
d94f17d
to
eca92ff
Compare
rikvl
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
I think you can go ahead and merge this. I couldn't find anything wrong with this, but can't say that I have fully understood everything.
For my benefit, maybe you can explain
- In
_copy_from_file, what would you expect the difference to be betweenkeyanditem.name? - What's the benefit of passing
fnamerather thanh5grouptoMPIArray.from_file?
This extends the hints argument to a dictionary to allow it to force distributed loading of datasets with no specific `__memh5_distributed` markers.
jrs65
force-pushed
the
parallel-load-with-no-attributes
branch
from
eca92ff
to
8523abf
Compare
jrs65
force-pushed
the
parallel-load-with-no-attributes
branch
from
8523abf
to
41496df
Compare
rikvl
approved these changes
Jan 31, 2024
This swaps from using the pytest-lazy-fixture plugin to the pytest-lazy-fixtures plugin which supports the underlying changes in pytest 8.
Also update the ruff config to avoid deprecated usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.