Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (api) getnext track api #55

Closed
wants to merge 1 commit into from

Conversation

hairmare
Copy link
Member

@hairmare hairmare commented Jun 3, 2020

This is a PoC for fixing the API parts needed for #52

@hairmare hairmare marked this pull request as draft June 3, 2020 07:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #55 into master will increase coverage by 0.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   78.90%   79.44%   +0.54%     
==========================================
  Files           1        1              
  Lines         602      618      +16     
  Branches      141      143       +2     
==========================================
+ Hits          475      491      +16     
  Misses        110      110              
  Partials       17       17              
Impacted Files Coverage Δ
klangbecken.py 79.44% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94daa0...6a56eda. Read the comment docs.

@hairmare hairmare force-pushed the feat/getnext_api branch 5 times, most recently from 4408830 to 6f17ec8 Compare June 3, 2020 10:59
@hairmare hairmare marked this pull request as ready for review June 3, 2020 11:04
@spameier
Copy link
Member

spameier commented Jun 3, 2020

I think it would be better to just return the id of next track by the API. The client already has a copy of index.json and can figure out the metadata of the track on his own. What do you think?

@spameier
Copy link
Member

spameier commented Jun 3, 2020

The most simple solution would be to fetch /data/prio.m3u directly from the client. Not really sexy though..

@hairmare
Copy link
Member Author

hairmare commented Jun 3, 2020

The most simple solution would be to fetch /data/prio.m3u directly from the client. Not really sexy though..

I'll give implementing it directly in the ui a go... Reading from an m3u is just about as unsexy as reading index.json on the client. Not that this code is much more sexy though.

@hairmare
Copy link
Member Author

hairmare commented Jun 3, 2020

Extending the API is indeed not needed since the frontend can access prio.m3u directly.

My frontend PR is now updated to not use this change: radiorabe/klangbecken-ui#90

@hairmare hairmare closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants