Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 (api) fix coverage report #54

Merged
merged 1 commit into from Jun 3, 2020

Conversation

hairmare
Copy link
Member

@hairmare hairmare commented Jun 3, 2020

Fixes #25

@codecov-commenter
Copy link

Codecov Report

Merging #54 into master will decrease coverage by 11.58%.
The diff coverage is 53.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #54       +/-   ##
===========================================
- Coverage   90.48%   78.90%   -11.59%     
===========================================
  Files           1        1               
  Lines         536      602       +66     
  Branches      120      141       +21     
===========================================
- Hits          485      475       -10     
- Misses         42      110       +68     
- Partials        9       17        +8     
Impacted Files Coverage Δ
klangbecken.py 78.90% <53.03%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03aca9f...1a2c68c. Read the comment docs.

@hairmare
Copy link
Member Author

hairmare commented Jun 3, 2020

Merging #54 into master will decrease coverage by 11.58%.
The diff coverage is 53.03%.

It will not, the coverage has been steadily decreasing since the codecov integration broke. This PR makes us notice again.

@hairmare hairmare requested a review from spameier June 3, 2020 07:11
@hairmare hairmare mentioned this pull request Jun 3, 2020
3 tasks
@spameier
Copy link
Member

spameier commented Jun 3, 2020

Merging #54 into master will decrease coverage by 11.58%.
The diff coverage is 53.03%.

It will not, the coverage has been steadily decreasing since the codecov integration broke. This PR makes us notice again.

That means I will be writing some tests soon ;).

@spameier spameier merged commit fbee74c into radiorabe:master Jun 3, 2020
@hairmare hairmare deleted the fix/missing-codecov branch June 3, 2020 08:50
@hairmare
Copy link
Member Author

hairmare commented Jun 3, 2020

Merging #54 into master will decrease coverage by 11.58%.
The diff coverage is 53.03%.

It will not, the coverage has been steadily decreasing since the codecov integration broke. This PR makes us notice again.

That means I will be writing some tests soon ;).

I created #56 so we remember to write tests in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix codecov submission from travisCI
3 participants