Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic linestrength cutoff #268

Open
erwanp opened this issue May 4, 2021 · 6 comments
Open

Automatic linestrength cutoff #268

erwanp opened this issue May 4, 2021 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers 💡gsoc Project ideas for Google Summer of Code physics involves the physics
Milestone
0.16

Comments

@erwanp
Copy link
Member

erwanp commented May 4, 2021 •
edited
Loading

Linestrength cutoff can be defined in calc_spectrum and SpectrumFactory with cutoff=

A good improvement, similar to #250 for automatic wstep adaptation, would be that the user inputs an acceptable error (0.1%, 1%, 10%, etc.), and the cutoff would be adjusted automatically. Modifications would be done in base.py > _cutoff_linestrength()
(Note : this "Automatic cutoff" should be another Issue, here we're only talking about allowing the "cutoff=None" syntax )

Originally posted by @erwanp in #251 (comment)
@erwanp erwanp added enhancement New feature or request good first issue Good for newcomers labels May 4, 2021
@erwanp erwanp added this to the 1.0 milestone May 4, 2021
@erwanp erwanp modified the milestones: 1.0, 0.9.31 Jun 5, 2021
@rishawsingh
Copy link

Hi @erwanp I would like to work on it

@erwanp
Copy link
Member Author

erwanp commented Aug 19, 2021

Hello ! This would actually be a very powerful addition to the code; and it's not very hard so a good first issue. I'm assigning you. Ask any question you like in the #general channel on Slack to help you get started !

@rishawsingh
Copy link

Alright thanks

@erwanp erwanp modified the milestones: 0.10.3, 0.10.4 Sep 23, 2021
@erwanp erwanp modified the milestones: 0.10.4, 0.10.5 Nov 1, 2021
@erwanp erwanp added the 💡gsoc Project ideas for Google Summer of Code label Dec 19, 2021
@erwanp erwanp added the physics involves the physics label Mar 13, 2022
@erwanp
Copy link
Member Author

erwanp commented Mar 13, 2022

@rishawsingh can I un-assign you from here ?

@sagarchotalia sagarchotalia mentioned this issue Apr 14, 2022
Closed
@anandxkumar anandxkumar modified the milestones: 0.14, 0.15 Oct 28, 2022
@RAJULDEV
Copy link

Hey @erwanp I am interested in this issue.
Please help me in getting started.

code29563 added a commit to code29563/radis that referenced this issue Mar 21, 2024
@code29563
re-worked cutoff_error parameter
a1f1624 
addressing issue radis#268 building on PR radis#451
@code29563 code29563 mentioned this issue Mar 21, 2024
Open
erwanp pushed a commit to code29563/radis that referenced this issue Apr 21, 2024
@code29563 @erwanp
re-worked cutoff_error parameter
5b4fac4 
addressing issue radis#268 building on PR radis#451
@erwanp erwanp modified the milestones: 0.15, 0.16 Jun 20, 2024
@erwanp
Copy link
Member Author

erwanp commented Jun 20, 2024

Moved to 0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers 💡gsoc Project ideas for Google Summer of Code physics involves the physics
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

Added cutoff_error parameter to enable Automatic Linestrength Cutoff
4 participants
@erwanp @anandxkumar @rishawsingh @RAJULDEV