Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug of get_baseline() function of Spectrum class #368

Closed
BlehMaks opened this issue Sep 8, 2021 · 0 comments 路 Fixed by #369
Closed

Bug of get_baseline() function of Spectrum class #368

BlehMaks opened this issue Sep 8, 2021 · 0 comments 路 Fixed by #369
Labels
bug Something isn't working interface not related to the physics of the code
Milestone

Comments

@BlehMaks
Copy link
Contributor

BlehMaks commented Sep 8, 2021

馃悰 Describe the bug

  1. radis.spectrum.operations.get_baseline() function has a peakutils module dependency which is not included in RADIS dependencies.

  2. There is a missing parameter in radis.spectrum.operations.get_baseline() function call. There also should be a wunit parameter for Spectrum.from_array() correct work.

馃挕 Possible solutions

  1. The first can be solved by: conda install -c conda-forge peakutils, suggested by @erwanp

  2. The second can be solved by adding wunit parameter to the line 1049 and 1076 of

1049: def get_baseline(s, var="radiance", wunit="nm", Iunit=None):
1076:         w1, baseline, var, wunit=wunit, unit=Iunit, name=s.get_name() + "_baseline"
@BlehMaks BlehMaks added the bug Something isn't working label Sep 8, 2021
@BlehMaks BlehMaks changed the title Bug fixes of get_baseline() function of Spectrum class Bug of get_baseline() function of Spectrum class Sep 8, 2021
@erwanp erwanp added the interface not related to the physics of the code label Oct 17, 2021
erwanp added a commit that referenced this issue Nov 14, 2021
 Fix of get_baseline() function of Spectrum class #368
@erwanp erwanp added this to the 0.11.0 milestone Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working interface not related to the physics of the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants