You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When MergeSlabs (//) is used between 2 spectra, one at equilibrium, the other one at non equilibrium, the resulting spectrum is wrongly assumed to be at equilibrium for some parameters such as radiance. See the exemple below.
When SerialSlabs (< or >) is used, the same problem occurs, and moreover the resulting spectrum is considered at equilibrium if the 2 spectra were at equilibrium (which makes no sense)
MergeSlabs should consider the spectrum at equilibrium ONLY if the 2 spectra were at equilibrium.
SerialSlabs should NEVER consider the resulting spectrum at equilibrium.
The .is_at_equilibrium() function should be tested.
💡 Possible solutions
PR ready
The text was updated successfully, but these errors were encountered:
🐛 Describe the bug
When MergeSlabs (//) is used between 2 spectra, one at equilibrium, the other one at non equilibrium, the resulting spectrum is wrongly assumed to be at equilibrium for some parameters such as radiance. See the exemple below.
When SerialSlabs (< or >) is used, the same problem occurs, and moreover the resulting spectrum is considered at equilibrium if the 2 spectra were at equilibrium (which makes no sense)
🖥 Steps To Reproduce
🎯 Expected behavior
MergeSlabs should consider the spectrum at equilibrium ONLY if the 2 spectra were at equilibrium.
SerialSlabs should NEVER consider the resulting spectrum at equilibrium.
The .is_at_equilibrium() function should be tested.
💡 Possible solutions
PR ready
The text was updated successfully, but these errors were encountered: