Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MergeSlabs and SerialSlabs regarding equilibrium assumption #371

Merged
merged 3 commits into from
Sep 26, 2021

Conversation

CorentinGrimaldi
Copy link
Collaborator

Description

Fix issue 370 about MergeSlabs and SerialSlabs assuming equilibrium wrongly

Fixes #370

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #371 (166f528) into develop (8e9158d) will increase coverage by 0.11%.
The diff coverage is 96.77%.

@@             Coverage Diff             @@
##           develop     #371      +/-   ##
===========================================
+ Coverage    76.08%   76.20%   +0.11%     
===========================================
  Files          152      152              
  Lines        17138    17166      +28     
===========================================
+ Hits         13040    13081      +41     
+ Misses        4098     4085      -13     

Copy link
Member

@erwanp erwanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge!

@erwanp erwanp added the bug Something isn't working label Sep 26, 2021
@erwanp erwanp added this to the 0.10.3 milestone Sep 26, 2021
@erwanp erwanp merged commit ace4020 into radis:develop Sep 26, 2021
@erwanp erwanp mentioned this pull request Sep 26, 2021
@CorentinGrimaldi CorentinGrimaldi deleted the fix_slabs_merging_equilibrium branch October 20, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MergeSlabs and SerialSlabs assume equilibrium wrongly
3 participants