Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading of single path in config file entry #257

Merged
merged 1 commit into from Apr 21, 2021

Conversation

CorentinGrimaldi
Copy link
Collaborator

Description

This pull request is to address ...

Fixes #

@erwanp erwanp added bug Something isn't working interface not related to the physics of the code labels Apr 21, 2021
@erwanp
Copy link
Member

erwanp commented Apr 21, 2021

@anandxkumar do you remember why this line was introduced with split()? It created some problems with paths containing spaces.

@anandxkumar
Copy link
Collaborator

anandxkumar commented Apr 21, 2021

@CorentinGrimaldi thanks for the fix!
@erwanp, the purpose was to create a list only. I probably skipped on the possibility that paths can have spaces too, I overlooked it :)

@erwanp
Copy link
Member

erwanp commented Apr 21, 2021

Ok perfect, that's what i understood. Merging!

@erwanp erwanp merged commit d9f9a57 into radis:develop Apr 21, 2021
@CorentinGrimaldi CorentinGrimaldi deleted the fix-path-reading-config-file branch April 22, 2021 09:04
@erwanp erwanp added this to the 0.9.30 milestone May 29, 2021
@erwanp erwanp mentioned this pull request May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working interface not related to the physics of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants