Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditions with slit_shape #260

Merged

Conversation

CorentinGrimaldi
Copy link
Collaborator

Fix untimely warning when rescaling caused by no shape saved in the conditions spectrum.

Description

This pull request is to address ...

Fixes #

Fix untimely warning when rescaling caused by no shape saved in the conditions spectrum.
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #260 (18ebf76) into develop (c6f544b) will decrease coverage by 1.53%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop     #260      +/-   ##
===========================================
- Coverage    76.80%   75.27%   -1.54%     
===========================================
  Files          117      119       +2     
  Lines        13868    14176     +308     
===========================================
+ Hits         10652    10671      +19     
- Misses        3216     3505     +289     

radis/spectrum/rescale.py Show resolved Hide resolved
@erwanp erwanp added bug Something isn't working post-process Related to the post-processing (ex: methods of Spectrum objects) labels Apr 28, 2021
@erwanp erwanp added this to the 0.9.30 milestone Apr 28, 2021
@erwanp erwanp merged commit 7a92477 into radis:develop May 4, 2021
@CorentinGrimaldi CorentinGrimaldi deleted the Fix_slit_shape_saving_condition branch May 5, 2021 09:15
@erwanp erwanp mentioned this pull request May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working post-process Related to the post-processing (ex: methods of Spectrum objects)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants