Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not parse local/global quanta if missing values #264

Merged
merged 1 commit into from May 2, 2021

Conversation

erwanp
Copy link
Member

@erwanp erwanp commented May 1, 2021

and pass without failing

fixes problem with HITEMP H2O unlabelled lines
fix #211

…failing

fixes problem with HITEMP H2O unlabelled lines
fix radis#211
@erwanp erwanp added this to the 0.9.30 milestone May 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #264 (25054fa) into develop (826cb72) will decrease coverage by 0.05%.
The diff coverage is 31.25%.

@@             Coverage Diff             @@
##           develop     #264      +/-   ##
===========================================
- Coverage    76.82%   76.76%   -0.06%     
===========================================
  Files          117      117              
  Lines        13883    13897      +14     
===========================================
+ Hits         10665    10668       +3     
- Misses        3218     3229      +11     

@erwanp erwanp merged commit 410422d into radis:develop May 2, 2021
@erwanp erwanp deleted the fix-lines-without-identifier branch May 2, 2021 13:36
@erwanp erwanp added the bug Something isn't working label May 7, 2021
@erwanp erwanp mentioned this pull request May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail safely for lines without identifiers (ex : Error computing HITEMP H2O )
2 participants