Fix Slit Dispersion, add automatic tests #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #270 +/- ##
===========================================
- Coverage 75.27% 75.05% -0.23%
===========================================
Files 119 119
Lines 14176 14182 +6
===========================================
- Hits 10671 10644 -27
- Misses 3505 3538 +33 |
…ed, faster apply_slit(), plot_slit() and offset_and_dilate() modified accordingly
erwanp
approved these changes
May 27, 2021
|
@CorentinGrimaldi all good or still wip? |
…and source of errors), the option is in apply_slit
CorentinGrimaldi
changed the title
CorentinGrimaldi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix slit dispersion, doing nothing for now (except in plot)
Rework of cut_slices(), tested in automatic test
Simplification of convolve_with_slit() which now only convolve ! (Unused option removed)
Fix apply_slit() with slit_dispersion
Make plot_slit() and apply_slit() coherent (same threshold used for cut_slices() when slit dispersion is specified)
Fix normalize() wrong unit for certain cases
Add automatic test for apply_slit() with slit_dispersion
Finished!