Fix: 305 #308
Merged
Fix: 305 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #308 +/- ##
===========================================
- Coverage 74.51% 74.50% -0.01%
===========================================
Files 121 121
Lines 14806 14809 +3
===========================================
+ Hits 11032 11033 +1
- Misses 3774 3776 +2 |
erwanp
requested changes
Jul 6, 2021
radis/misc/profiler.py
Outdated
| / total_sum_verbose_wise[i] | ||
| * 100, | ||
| ) | ||
| except: |
There was a problem hiding this comment.
Good practice : can you always precise the excepted error ? (ZeroDivisionError probably here)?
Having an open except comment makes the code harder to read.
erwanp
approved these changes
Jul 7, 2021
|
Approved ; @minouHub I let you boldly click the Merge button ! |
anandxkumar
added this to In progress
in GSOC21 : Automatic Lineshape Engine
via automation
|
I fired it :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request Fixes #305, updates profiler keys and removes round function for calculation time.