Dimensioned Spectrum.max() function #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he correct units) improved error messages
…ault this is an official astropy unit and therefore will help dimensioned-operations
erwanp
added
post-process
Codecov Report
@@ Coverage Diff @@
## develop #395 +/- ##
===========================================
- Coverage 75.67% 75.48% -0.19%
===========================================
Files 153 156 +3
Lines 17430 17574 +144
===========================================
+ Hits 13190 13266 +76
- Misses 4240 4308 +68 |
|
@CorentinGrimaldi you can approve & merge directly |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.max now returns dimensioned quantity. Allows :
as another way to normalize a spectrum
(and makes it much easier to multiply / subtract a Spectrum based on min/max values from another Spectrum, without having to worry about units ! )