Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #356 #397

Merged
merged 2 commits into from Nov 13, 2021
Merged

Fixes #356 #397

merged 2 commits into from Nov 13, 2021

Conversation

anandxkumar
Copy link
Collaborator

Description

This pull request converts int value isotope into string for fetch_hitemp.

Fixes #356

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #397 (a7eb649) into develop (eb9258b) will increase coverage by 0.02%.
The diff coverage is 36.00%.

@@             Coverage Diff             @@
##           develop     #397      +/-   ##
===========================================
+ Coverage    75.38%   75.40%   +0.02%     
===========================================
  Files          156      156              
  Lines        17673    17681       +8     
===========================================
+ Hits         13323    13333      +10     
+ Misses        4350     4348       -2     

@anandxkumar
Copy link
Collaborator Author

Should we add list support for isotopes like isotope=[1,2,3]?

Copy link
Member

@erwanp erwanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, you can merge!
I think list is not needed ; unless users end up asking for it !

@erwanp erwanp added this to the 0.11.0 milestone Nov 13, 2021
@anandxkumar anandxkumar merged commit 01a6544 into radis:develop Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch_hitemp fails if isotope=int
3 participants