Updated travis.yml for micromamba #426
Conversation
|
Great work @Supriya1702, the Travis has been occupied by another pull request, so we will have to wait till it gets terminated to see if your changes are working. |
|
@anandxkumar somehow this PR did not trigger a Request on Travis-CI for automatic testing. I thought it may be because it's @Supriya1702 's first contribution; but #425 was also a first-time contribution and did work. @Supriya1702 : when pushing the changes suggested by @anandxkumar I hope it will initiate the CI-test. Else, I'll contact the Travis team. |
|
Hello @erwanp @anandxkumar , seems like the micromamba environment got created on |
|
hey @Supriya1702, please check this issue , I think this should be relevant. 😅 |
|
Hello @Supriya1702 , well done ! The errors are not related to your changes, I think it's related to some new Pandas version . I'll look it up |
Codecov Report
@@ Coverage Diff @@
## develop #426 +/- ##
===========================================
- Coverage 77.08% 77.03% -0.06%
===========================================
Files 161 161
Lines 18664 18664
===========================================
- Hits 14388 14378 -10
- Misses 4276 4286 +10 |
|
Tests pass except from a tiny trailing-space formatting test; I'm merging. Congratulatinos @Supriya1702 for this first contribution ! |
| # Update python version in environment | ||
| - sed -i -E 's/(python=)(.*)/\1'$TRAVIS_PYTHON_VERSION'/' ./environment.yml | ||
| # Create conda environment | ||
| - conda env create -n radis-env -f environment.yml | ||
| - micromamba install xtensor -c conda-forge -y |
There was a problem hiding this comment.
@Supriya1702 why was Xtensor added here?
There was a problem hiding this comment.
@erwanp, In order to install the dependencies of radis mentioned in environment.yml we need to install some prerequisites based in the xtensor library of micromamba, else the dependencies won't install and the build will fail
There was a problem hiding this comment.
We don't use Xtensor internally in Radis, so it's probably a radis dependency that requires it. Isn't Mamba suppose to find this out by itself?
There was a problem hiding this comment.
I tried without installing the xtensor, upon creating the virtual environment it was showing errors that some important library missing so can't install dependencies. xtensor contains some important c++ based libraries for GCC compiler:
Following are dependencies in xtensor:
xtensor == 0.21.5
├─ libgcc-ng [>=7.3.0]
│ ├─ _libgcc_mutex [0.1 conda_forge]
│ └─ _openmp_mutex [>=4.5]
│ ├─ _libgcc_mutex already visited
│ └─ libgomp [>=7.3.0]
│ └─ _libgcc_mutex already visited
├─ libstdcxx-ng [>=7.3.0]
└─ xtl [>=0.6.9,<0.7]
├─ libgcc-ng already visited
└─ libstdcxx-ng already visited
I believe these libraries are essential for installing basic libraries in micromamba, which can be inferred from the fact that it is very light weight so some dependencies don't come in the base environment.
Also, why has the recent Travis build failed, I tested locally it was working fine. build
File "/home/travis/micromamba/envs/radis-env/bin/pytest", line 8 in
Aborted
The command "xvfb-run pytest --cov=./" exited with 134.
Reference
There was a problem hiding this comment.
Ok thank you !
for Travis build, it's not related --> more on Slack !
Description
This pull request replaces miniconda with micromamba in
.travis.yml.@erwanp @anandxkumar I ran the changed code on my system it passed the tests but got stuck at 8th test of
test_examples.pysame happens when I use conda environment, I wonder what the issue is.Fixes #423