Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint errors #436

Merged
merged 6 commits into from Apr 2, 2022
Merged

Conversation

encrypted-soul
Copy link
Member

Description

Fixes lint errors introduced in #435

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #436 (1ec9df7) into develop (5438538) will not change coverage.
The diff coverage is 88.23%.

@@           Coverage Diff            @@
##           develop     #436   +/-   ##
========================================
  Coverage    77.07%   77.07%           
========================================
  Files          161      161           
  Lines        18640    18640           
========================================
  Hits         14366    14366           
  Misses        4274     4274           

@anandxkumar
Copy link
Collaborator

anandxkumar commented Mar 27, 2022

It passes locally! Try running pre-commit run --all-files again and push it

Re-running Travis: Failed again at the same place

@anandxkumar
Copy link
Collaborator

Got the error, it's because locally we are using an old version of pre-commit, as soon as I updated the pre-commit, it gives the same error on travis

@anandxkumar
Copy link
Collaborator

@erwanp you may want to look into the issue, tried to replicate travis linting locally, passes locally but fails remotely

@Supriya1702
Copy link
Collaborator

Hello @anandxkumar, I tried testing linting on my system/ I was able to re-create the error when using the current version of black in pre-commit-config - line- 3. If I use it upto version 22.1.0 it gives the same error as on travis:

black....................................................................Failed
- hook id: black
- exit code: 1
Traceback (most recent call last):
  File "/home/travis/.cache/pre-commit/repopkv29orr/py_env-python3/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "/home/travis/.cache/pre-commit/repopkv29orr/py_env-python3/lib/python3.8/site-packages/black/__init__.py", line 6606, in patched_main
    patch_click()
  File "/home/travis/.cache/pre-commit/repopkv29orr/py_env-python3/lib/python3.8/site-packages/black/__init__.py", line 6595, in patch_click
    from click import _unicodefun  # type: ignore
ImportError: cannot import name '_unicodefun' from 'click' (/home/travis/.cache/pre-commit/repopkv29orr/py_env-python3/lib/python3.8/site-packages/click/__init__.py)

But when I use the latest version 22.3.0 it formats all the black linting and passes. You may want to check it on your end!

@anandxkumar
Copy link
Collaborator

Great catch @Supriya1702, it seems like that is the issue, I have updated the black to the latest version, and seems like the error has been reciprocated and has been fixed

@anandxkumar
Copy link
Collaborator

@Supriya1702 the issue has been resolved, I would be merging it. You may count it as your contribution 😉

@anandxkumar anandxkumar merged commit d40cad6 into radis:develop Apr 2, 2022
Copy link
Collaborator

@anandxkumar anandxkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@erwanp erwanp added this to the 0.12.1 milestone Apr 3, 2022
@encrypted-soul encrypted-soul modified the milestone: 0.12.1 Apr 3, 2022
@encrypted-soul encrypted-soul added the refactor requires changes in code architecture label Apr 3, 2022
@erwanp erwanp mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor requires changes in code architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants