Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inaccessible links in several documents #437

Merged
merged 6 commits into from Apr 2, 2022
Merged

Fixed inaccessible links in several documents #437

merged 6 commits into from Apr 2, 2022

Conversation

TranHuuNhatHuy
Copy link
Collaborator

@TranHuuNhatHuy TranHuuNhatHuy commented Mar 27, 2022

Description

This pull request is to correct the inaccessible links in several documentations, mentioned in #439.

Fixing the two inaccessible links in the original documentation:
1. The detailed installation guide, with wrong link
2. The Github link for radis app
@TranHuuNhatHuy TranHuuNhatHuy changed the title Fixed inaccessible links in README description Fixed inaccessible links in README description and in readthedocs document Apr 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #437 (957cd4d) into develop (d40cad6) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #437      +/-   ##
===========================================
- Coverage    77.07%   77.01%   -0.06%     
===========================================
  Files          161      161              
  Lines        18640    18640              
===========================================
- Hits         14366    14356      -10     
- Misses        4274     4284      +10     

@TranHuuNhatHuy TranHuuNhatHuy changed the title Fixed inaccessible links in README description and in readthedocs document Fixed inaccessible links in several documents Apr 1, 2022
@anandxkumar
Copy link
Collaborator

anandxkumar commented Apr 2, 2022

Hi @TranHuuNhatHuy, you may want to pull the latest development branch in your repo and then run pre-commit install to add it to git hooks. pre-commit run --all-files before pushing code back or better use git commit -am "message" to run linting before committing the changes , if the test fails run the git commit -am "message" again to save the changes

@anandxkumar
Copy link
Collaborator

anandxkumar commented Apr 2, 2022

The test failed but for test and coverage, not related to your code. You may want to trigger Travis again by committing an empty commit i.e. git commit --allow-empty -am "Trigger"

@TranHuuNhatHuy
Copy link
Collaborator Author

Hello @anandxkumar. Thank you so much for helping me. I tried to commit an empty commit in order to trigger Travis again but somehow it doesn't respond. Should I wait for a while before retrying?

@anandxkumar
Copy link
Collaborator

anandxkumar commented Apr 2, 2022

Are you sure that you pushed the commit, because it is not showing here in the PR. Try git commit --allow-empty -m "Trigger".

@anandxkumar
Copy link
Collaborator

Tests passed, nice work!

@anandxkumar anandxkumar merged commit 6285e52 into radis:develop Apr 2, 2022
@TranHuuNhatHuy
Copy link
Collaborator Author

@anandxkumar Thanks to your wholesome support !

@erwanp erwanp added this to the 0.12.1 milestone Apr 2, 2022
@erwanp erwanp added the documentation related to the docs https://radis.readthedocs.io/ label Apr 2, 2022
@erwanp erwanp mentioned this pull request Apr 3, 2022
@erwanp erwanp mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation related to the docs https://radis.readthedocs.io/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants