-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement astropy unit conversion to rescale_path_length() #445
Conversation
Nice ! I think it should be radis.spectrum.Spectrum.rescale_path_length there is a script in doc/gendocs.sh that allows you to generate docs locally; helps the debugging. You may need to install the doc specific requirements |
What we'll need before merging is to add tests. There is a test_rescale.py file. You can add a new function there, testing the units. You can use a precomputed spectrum such as
and you could, for instance, compare the |
Codecov Report
@@ Coverage Diff @@
## develop #445 +/- ##
===========================================
+ Coverage 77.06% 77.09% +0.02%
===========================================
Files 161 161
Lines 18641 18664 +23
===========================================
+ Hits 14366 14389 +23
Misses 4275 4275 |
@erwanp thank you for the reviews. Last commit features two changes according to your suggestions:
|
Excellent, merging! |
Fixes #444 |
Description
This pull request is to address #444. Now we can use astropy units for the input arguments of
rescale_path_length()
.Beside, currently on the RADIS documentation,
rescale_path_length()
has 2 references:For [1]:
.. minigallery:: radis.Spectrum.rescale_path_length
.For [2], it's just kinda empty here.