Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue#443 #447

Merged
merged 3 commits into from Apr 12, 2022
Merged

Fixes Issue#443 #447

merged 3 commits into from Apr 12, 2022

Conversation

Supriya1702
Copy link
Collaborator

Description

This PR does the following:

  • If truncation=None for broadening_method='voigt' for optimization='simple' or 'min-RMS method it raises NotImplementedError
  • If truncation is negative it raises value error
  • Allows computation for broadening_method == "voigt" and truncation == None for optimization=None

Fixes #443

@anandxkumar anandxkumar added the bug Something isn't working label Apr 11, 2022
@anandxkumar anandxkumar added this to the 0.12.1 milestone Apr 11, 2022
@anandxkumar
Copy link
Collaborator

Tested for different cases, works fine on my end, Good job!
@erwanp should truncation=None work for optimization=None for broadening_method='voigt'?

Copy link
Member

@erwanp erwanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, good work!

  1. are you sure optimization=None is implemented?

  2. We'd need a quick test, for instance one making sure an error is raised if negative truncation is given, and one making sure truncation=None does what we want. If you need help implementing tests please reach out on Slack

radis/lbl/factory.py Outdated Show resolved Hide resolved
radis/lbl/factory.py Outdated Show resolved Hide resolved
@Supriya1702
Copy link
Collaborator Author

Hello @erwanp, I added test for checking negative truncation and truncation==None. I found that truncation=None works for broadening_method='voigt' for optimization=None but gives error when used fft. Oppositely in optimization='simple, truncation=None works for fft but fails for voigt, so I added the tests accordingly

@erwanp
Copy link
Member

erwanp commented Apr 12, 2022

Great, merging !

@erwanp erwanp merged commit 57457b5 into radis:develop Apr 12, 2022
@erwanp erwanp mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add truncation=None option
3 participants