Add/common api #480
Merged
Add/common api #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@anandxkumar @gagan-aryan we're having new crashes on the Tests. I do not have them locally, and think it can be due to newer Vaex versions. |
enforcing no ImportError unless ran from the same file (script mode)
# Conflicts: # radis/io/exomol.py
|
Merging ground work for common API. Will be used in Exojax : |
erwanp
added
refactor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Refactor towards a common API for Radis & ExoJax
fetch_...RADIS interface . See this comment : Toward a common API HajimeKawahara/exojax#257 (reply in thread)Preliminary work : #465
Common API discussion : HajimeKawahara/exojax#257